http://local.domain.dev/

Other Settings…

Force default language - No Add URL prefix - Yes Force URL prefix - No

Nope afraid not, it’s on my local and client server protected by firewall (dev.domain.com - so assume will have the same issue).

Added the query string and nothing happens…? Tried turning on debug too, still nothing. So bit of rummaging around…

In this example I’m going from: http://local.domain.dev/nl/about to: http://local.domain.dev/about

Publisher_session.php line 640: $url = ee()->publisher_helper_url->add_trailing_slash($url); $url has the value of: http://local.domain.dev/about

line 656: ee()->publisher_lib->prev_lang_id = $this->session_language_id; $this->session_language_id has the value 2 (Dutch, which is correct).

line 659: $current_url = $this->get_current_url(); $current_url has the value: http://local.domain.dev/about

Line 673 then balls it all up: $url = ee()->publisher_helper_url->set_prefix($url); $url is then http://domain.dev/nl/about

Publisher_helper_url.php set_prefix method calls get_site_index

ee()->config->_global_vars[‘root_url’] is incorrectly set

…Plot thickens!

EE Config file is set like so: $config[‘site_url’] = “http://${_SERVER[‘HTTP_HOST’]}/”; Which outputs correctly: http://local.domain.dev/

But on line 207 of Publisher_session.php: ee()->config->item(‘site_url’) = http://domain.dev/ on the fronted. Exactly the same place in your code output from within the Control Panel shows the domain correctly http://local.domain.dev/

Disabling Extensions and outputting site_url into the template results in the incorrect URL still.

Hard coding the site_url config to: $config[‘site_url’] = “http://local.domain.dev/”; Still results in it changing.

Any ideas…?

Oh boy, that was painful. It’s a multi-site so the site_url was being overrode inside the index.php. Doh!

Right back to the other issue…

How do I set it so that English always works without the prefix and other languages require it?

Can it only be done via the language switcher and never direct URL changes?

Possibly I’m muddying the ticket and these are different issues I’m having, but they do seem related. Another simplified example of the issue below - it seems that it needs to refresh on the current language to register it’s that language…

http://local.domain.dev/en - Shows English http://local.domain.dev/nl - Incorrectly shows English Refresh http://local.domain.dev/nl - Shows Dutch http://local.domain.dev/en - Incorrectly shows Dutch Refresh http://local.domain.dev/en - Shows English

Here’s where I’ve got to…

The session_language_id doesn’t seem to ever get changed, which leads to the same language being shown even though the prefix changed.

So I’ve explored tweaks to the code based on your gist code to try to uncover the solution in the vain hope it’ll uncover the cause. None of the settings have changed from the above (including “publisher_hide_prefix_on_default_language” still commented out).

Changes to set_properties function… Around line 333:

+     $segments = ee()->uri->segments;

        // Front-end requests require a bit more
        if ( !$this->session_language_id)

Around line 365:

}
        else
        {
            // See if the language code in the segment is in our language list.
            // Allows for manual changes of language segment and immediate content updates.
            $lang_id = isset($segments[1]) ? array_search($segments[1], $this->language_codes) : FALSE;

            if ($lang_id)
            {
                $this->session_language_id     = $lang_id;
                ee()->publisher_lib->lang_id   = $lang_id;
            }
                ee()->publisher_lib->lang_code = isset($this->language_codes[$this->session_language_id]) 
                                            ? $this->language_codes[$this->session_language_id] 
                                            : $this->default_language_code;
            $this->set('site_language', $this->session_language_id);

This now seems to mostly work correctly with regards to switching language via the URL. But if I’m on the Dutch site (nl) and remove the prefix completely, it redirects to include the prefix (which would be the preferred behaviour of the English albeit reversed - to prevent access on the prefix). If I’m on English it correctly allows access to the URL without the prefix, but both prefix and non-prefix are available, so bad for duplicate content penalties.

So could you either help clarify why my usage case (with unmodified code) doesn’t work, as surely this is required and valid usage of the add-on? Or can you give me pointers as to what code needs modifying to correctly: Redirect to non-prefix URL if “publisher_hide_prefix_on_default_language” = true and default_language_code = ee()->publisher_lib->lang_code Change the language code/ID to default if URL accessed without prefix (instead of redirecting to add last used prefix).

No cookie domain specified. Both CP and User Session Types are Cookies. I’ve also changed the CP to Cookies & Session and no difference.

I’ve tried testing in another browser, clearing all cookies and cache.

I’ve commented out all my code additions, except this line:

$segments = ee()->uri->segments;

This seems to solve some of the problems and almost replicate where I was above bar the redirection for dutch:

/en doesn’t get redirected to just / (therefore both URLs accessible) If going from /nl to / it remains on the “/” but in Dutch (so both URLs accessible and no prefix defaulting to last used language).

Will try without the added line and tweaking the settings…

url title with prefix - nope.

$segments = ee()->uri->segments;

can’t be removed as it then stops the language from changing.

$config['publisher_hide_prefix_on_default_language'] = "y";

can’t be added as again that results in the same issue (language doesn’t change).

Oddly going from /nl to / now redirects back to /nl (albeit it shouldn’t redirect but show the English).

Jinx - was just typing exactly the same - I’m going to try and replicate on a public facing URL, so I can give you access and also see if it behaves the same.

I’ll generate a new ticket with the details in and also another issue regarding Field Pack or Playa issue and keep that issue separate. I’ll try and sort it out in the next few hours.

Thanks.

Hi, up to you? If it’s easier because of the log on details assigned to that ticket, then yep, that’s fine.

Done. I’ve set it to: “y” not “yes” 😉
if ($setting == ‘y’ AND ee()->publisher_lib->lang_id == ee()->publisher_lib->default_lang_id)

Now it doesn’t pick up the language at all. You should be able to change config settings via Deeploy Helper module.

“url translations” - not yet, but the intention is to use it later - but that’s fine to turn off for the time being.

{site_url} - thanks will do, basically haven’t progressed much further until this issue is resolved. I’ve been displaying at the top of the template to see how it’s interpreting the URL.

Hi Brian, afraid not. Sorry for the delay, had shutdown over Christmas and this is the first chance I’ve had to pick this up again.

So there are 2 issues outstanding - default prefix can’t be hidden and redirection without prefix is incorrect.

/en/about - English site. /nl/about - Dutch site.

Fine and correct (ish).

From /nl/about type: /about (no prefix) and it redirects to /nl/about (incorrect, but not the point I’m trying to make…) From /en/about type: /about (no prefix) and it redirects to /nl/about - Incorrect as based on the rules above, English was the last language visited and English is the default, but it seems to be just redirecting to the last language in the list.

Soooo, could this redirect issue be just that without the language identifier, it’s getting the last language in the list, instead of looking at the default?

But, I’ve also got:

$config['publisher_hide_prefix_on_default_language'] = "y";

So the “en” shouldn’t even be appearing as a prefix.

If I try to access the homepage with no prefix, there’s no redirection but it will always deliver the dutch page.

:(

Hi Brian,

/en/about now gets redirected/rewritten to /about (cool) But visit the homepage (no prefix or just /en/) and it gets a redirection error and never loads.

/about (entered manually in the URL) then visit /nl/about (manually) - all fine. From there, enter /about again in the URL manually and it redirects to /nl/about (showing Dutch) instead of no redirection and showing English.

Peter

The changes did correctly redirect the English though - so you couldn’t get to /en/ - which is good. So right place, just seems to go wonky when no URL (segments) exists and from /nl/ to no prefix, still picks up session.

The site is purely for your use, so you don’t have to revert anything - up to you.

Nice - thank you. Alas it still doesn’t want to go from /nl/about to /about (manually changing the URL) which redirects back to /nl/about, but going from /nl/about to /en/about does correctly redirect to /about (showing English). I thought that wouldn’t be too much of an issue, but if you consider the Dutch homepage:

/nl

It would be quite logical to just remove the /nl manually in the browser URL and expect English, but this redirects back to /nl. So the only way to get to the English site is to use the language switcher (which sits in the footer) or to manually replace /nl with /en, which then correctly takes them to / (no prefix).

If that’s not possible to resolve (appreciate all the time you’ve already spent on this) then I can live with that - it’s solid in all the other previous issues so I’m happy.

Peter

Yay! Magic. All perfect now. Many thanks again for your support - very much appreciated.