EE compatibility updates:

  • Publisher is EE5 compatible, but it does not currently support the Fluid field.

ExpressionEngine.com licenses:

  • If you purchased an add-on from expressionengine.com, be sure to visit boldminded.com/claim to add the license to your account here on boldminded.com.

Ticket: After deleting entry, approval is still pending

Status Resolved
Add-on / Version Publisher Lite 3.2.2
Severity
EE Version 5.3.2

Andrew Studios

Dec 03, 2020

Hey Brian,

Hopefully an easy one for you. It seems that if an entry is submitted for approval, then deleted, the approval is not removed from the ‘pending approvals’ list. Clicking on the link to go to the entry from the approvals list gives the EE error “there are no entries matching the selected criteria” message (this error is expected as the entry no longer exists!).

One thing I should note ... the entries in question were removed through the Zenbu entry list (ie select one or more entries, then choose to delete). The entries were removed correctly via this addon, so I can’t imagine this is the issue.

Happy to do further testing if required.

Cheers!

Andrew

#1

BoldMinded (Brian)

Dec 04, 2020

I took a quick look at the code and don’t see any reason why it shouldn’t be deleted. I’ll try to replicate it locally though. Thanks for reporting it.

#2

BoldMinded (Brian)

Dec 04, 2020

My first test seemed to delete the approval just fine. In the ApprovalAbstract.php file, line 169, add this to see if the function is called in your environment. I don’t see why it wouldn’t unless something is performing a redirect before the event can be triggered.

public function delete($entityId, $entityType = 'entry', $languageId = null)
    {
        var_dump('approval delete called'); die;

        if (!$languageId) {
            $languageId = $this->request->getCurrentLanguage()->getId();
        }
#3

BoldMinded (Brian)

Dec 27, 2020

Closing this one too b/c I haven’t heard anything and I wasn’t able to replicate.

Login to reply